refactor(network): optimized client mem usage#1483
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
+ Coverage 86.22% 86.25% +0.02%
==========================================
Files 148 148
Lines 14157 14158 +1
==========================================
+ Hits 12207 12212 +5
+ Misses 1417 1416 -1
+ Partials 533 530 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiaost
force-pushed
the
refactor/client-mem-usage
branch
3 times, most recently
from
a72dca0 to
93a1e5e
Compare
Use Read() instead of Peek()+Skip() in ReadByte() and appendBodyFixedSize() to avoid holding references to the underlying buffer. Peek() returns slices that reference the internal buffer, preventing it from being released or reused until the reference is dropped. Also updated cloudwego/gopkg dependency and moved connstate import to gopkg/net/connstate.
xiaost
force-pushed
the
refactor/client-mem-usage
branch
from
93a1e5e to
52be57c
Compare
ppzqh
approved these changes
Mar 5, 2026
DMwangnima
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Read() instead of Peek()+Skip() in ReadByte() and appendBodyFixedSize()
to avoid holding references to the underlying buffer. Peek() returns slices
that reference the internal buffer, preventing it from being released or
reused until the reference is dropped.
Also updated cloudwego/gopkg dependency and moved connstate import to
gopkg/net/connstate.